Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Progress Linear/Circular Component #134

Closed
wants to merge 4 commits into from
Closed

Feature: Progress Linear/Circular Component #134

wants to merge 4 commits into from

Conversation

peec
Copy link
Contributor

@peec peec commented Jul 15, 2015

This PR gives 2 new components:

  • Progress Circular
  • Progress Linear

These works just like ember-material-design.

Converted from http://mike1234.com/ember-material-design/ ( Thanks @mike1o1 ).

Notes:

  • Added Sniffer service. Also added a modified service of "constants", named "browser-compatibility" which is used by the linear progress component. A service fits very well for this purpose because the detection only needs to be done once and not per component basis. So I also added these services which the progress-linear component needs to create dynamic transforms attribute on the DOM.

@peec peec changed the title Convert progress-linear from ember-material-design repo. Props to mik… Feature: Progress Linear Component Jul 15, 2015
@peec peec mentioned this pull request Jul 17, 2015
Closed
11 tasks
@peec
Copy link
Contributor Author

peec commented Jul 18, 2015

@miguelcobain This PR ( progress-linear ) is now the only thing left before autocomplete #132 is done. This PR implemented as ember-material-design. Could you take a look and possibly merge this when you have time?

@peec peec changed the title Feature: Progress Linear Component Feature: Progress Linear/Circular Component Jul 19, 2015
@peec
Copy link
Contributor Author

peec commented Jul 19, 2015

@miguelcobain I see that progress-linear is now merged, thanks. I did some changes today, in this PR to also include paper-progress-circular as well. Should i create a new PR for progress circular now that linear is in master?

@miguelcobain
Copy link
Collaborator

@peec A new PR would be awesome!

@peec
Copy link
Contributor Author

peec commented Jul 19, 2015

Closed, ref #136

@peec peec closed this Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peec @miguelcobain